Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a config option to store only minimal metadata #937

Merged
merged 1 commit into from
Aug 24, 2017

Conversation

eapache
Copy link
Contributor

@eapache eapache commented Aug 23, 2017

Typically the default is just to fetch and store all topics, as it is
simpler and more convenient not to have to go to the network for every
new topic that is needed. However this can use a lot of memory for
clusters with many topics and partitions, so add a flag which can be
unset in order to just store the minimal topic information needed so
far.

As suggested in #931.

@chandradeepak does this solve your problem?

Typically the default is just to fetch and store all topics, as it is
simpler and more convenient not to have to go to the network for every
new topic that is needed. However this can use a lot of memory for
clusters with many topics and partitions, so add a flag which can be
unset in order to just store the minimal topic information needed so
far.
@eapache eapache requested a review from wvanbergen August 23, 2017 13:10
Copy link
Contributor

@wvanbergen wvanbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightforward 👌

@chandradeepak
Copy link
Contributor

i will check with this pull request and let you know . thanks for considering it .

@chandradeepak
Copy link
Contributor

the pull request kind of stopped the growth . i think it is good to merge to master. Thanks for the quick fix .

@eapache eapache merged commit 55b3f6a into master Aug 24, 2017
@eapache eapache deleted the optional-minimal-metadata-set branch August 24, 2017 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants