FIX: Remove dupeAndSort in Replicas and InSyncReplicas #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I'm not sure why I originally added this logic. The sorting does seem incorrect. Creating a copy of the array is a good practice for API safety though to avoid complications when callers mutate the result. Please leave the duplication part in place. |
meaningful to Kafka(preferred leader)
git-hulk
force-pushed
the
Fix/remove-depeAndSort
branch
from
4b5702e to
240ddc7
Compare
|
@eapache Fixed and rebased, thanks for the review. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It shouldn't sort the replicas and isr while the order is meaningful to Kafka(preferred leader)