Add a buffer around the broker's net.Conn for reads #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces the number of read syscalls caused by small, sequential reads on the broker's net.Conn.
|
👍 |
|
I am actually incredibly surprised to learn that the Go stdlib doesn't do this for you... Do you have any benchmarks showing how much of an improvement this is? |
|
I don't have anything scientific, but I did manually profile an app before & after this change and saw a reduction in time spent in |
| buf *bufio.Reader | ||
| } | ||
|
|
||
| func NewBufConn(conn net.Conn) *bufConn { |
There was a problem hiding this comment.
method should not be public
|
👍 from me if you un-export |
eapache
added a commit
that referenced
this pull request
Dec 15, 2015
Add a buffer around the broker's net.Conn for reads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the number of read syscalls issued by short, sequential reads on the broker's net.Conn. A similar technique is used in the
net/httppackage.