Add kafka 0.9 #572
Merged
Add kafka 0.9 #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix one new constraint on the broker ID which must now be small unless you configure otherwise.
|
👍 |
|
@wvanbergen review new extra commit please |
|
👍 again :) |
|
OK, failure is that before an |
Looks like it has non-trivial problems we'll need to solve.
|
Added a skip, even working around that there are several problems with the offset manager. I'll file a ticket instead. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix one new constraint on the broker ID which must now be small unless you
configure otherwise. Fortunately it seems older versions just ignore unrecognized config stanzas.
P.S. I believe this is because 0.9 now optionally auto-generates broker IDs for you within a given range? At some point we need to find/read a good changelog.