Fix OffsetCommitRequest #390
Conversation
Apparently the kafka protocol spec has been inconsistent for a while, documenting v1 of this message but claiming it was still v0. Jun finally updated it, so now we can properly implement *both* versions correctly.
|
Do we have to send the right version of the message to the right Kafka version? Or can kafka 0.8.2 handle the old message as well? Given that offset management doesn't really work in 0.8.1 I have no toruble always using the new version, or at least make that the default. |
|
AFAIK 0.8.2 can handle both, otherwise you wouldn't necessarily be able to upgrade without downtime. |
|
The spec now says "v0 (supported in 0.8.1 or later)" |
|
Yeah; I think Kafka 0.8.1 can read the message, but it doesn't do anything useful with it. The functional test for offset management was failing pretty hard on kafka 0.8.1.1 when using the v0 message format. So I don't see it as very useful to keep the v0 format around. |
|
We weren't sending the v0 format before, we were sending v1 and saying v0 because the wiki was wrong :( |
|
Aha OK. 👍 in that case |
Apparently the kafka protocol spec has been inconsistent for a while,
documenting v1 of this message but claiming it was still v0. Jun finally updated
it, so now we can properly implement both versions correctly.
@Shopify/kafka