From 9c86a82687637bad9e5ccd0b37e3c6dfa7dab44d Mon Sep 17 00:00:00 2001 From: Dominic McPhee Date: Wed, 10 Mar 2021 10:42:44 -0500 Subject: [PATCH 1/6] [TextField] Replace autocomplete off with nope --- src/components/TextField/TextField.tsx | 4 +++- src/components/TextField/tests/TextField.test.tsx | 13 ++++++++++--- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/src/components/TextField/TextField.tsx b/src/components/TextField/TextField.tsx index fccd0f65400..0aae53f0f11 100644 --- a/src/components/TextField/TextField.tsx +++ b/src/components/TextField/TextField.tsx @@ -517,7 +517,9 @@ function normalizeAutoComplete(autoComplete?: boolean | string) { if (autoComplete === true) { return 'on'; } else if (autoComplete === false) { - return 'off'; + return 'nope'; + } else if (autoComplete === 'off') { + return 'nope'; } else { return autoComplete; } diff --git a/src/components/TextField/tests/TextField.test.tsx b/src/components/TextField/tests/TextField.test.tsx index 4830abe6de1..f6aac555b6d 100644 --- a/src/components/TextField/tests/TextField.test.tsx +++ b/src/components/TextField/tests/TextField.test.tsx @@ -186,14 +186,21 @@ describe('', () => { expect(textField.find('input').prop('autoComplete')).toBeUndefined(); }); - it('sets autoComplete to "off" when false', () => { + it('sets autoComplete to "nope" when false', () => { const textField = mountWithAppProvider( , ); - expect(textField.find('input').prop('autoComplete')).toBe('off'); + expect(textField.find('input').prop('autoComplete')).toBe('nope'); }); - it('sets autoComplete to "on" when false', () => { + it('sets autoComplete to "nope" when "off"', () => { + const textField = mountWithAppProvider( + , + ); + expect(textField.find('input').prop('autoComplete')).toBe('nope'); + }); + + it('sets autoComplete to "on" when true', () => { const textField = mountWithAppProvider( , ); From aa2fb50e5c10d83ad0a714b520a3cd8f5d82da9f Mon Sep 17 00:00:00 2001 From: Dominic McPhee Date: Wed, 10 Mar 2021 10:54:44 -0500 Subject: [PATCH 2/6] Add to UNRELEASED --- UNRELEASED.md | 1 + 1 file changed, 1 insertion(+) diff --git a/UNRELEASED.md b/UNRELEASED.md index 963aa6cad90..7b1689eb5c2 100644 --- a/UNRELEASED.md +++ b/UNRELEASED.md @@ -16,6 +16,7 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f - Ensured `@charset` declaration is the first thing in our styles.css file ([#4019](https://github.com/Shopify/polaris-react/pull/4019)) - Fix `Modal.Section` divider color to match header and footer divider ([#4021](https://github.com/Shopify/polaris-react/pull/4021)) - Remove focus ring on click for ActionList ([#4034](https://github.com/Shopify/polaris-react/pull/4034)) +- Updated `` to use `autocomplete=nope` instead of `autocomplete=off` ([#4053](https://github.com/Shopify/polaris-react/pull/4053)) ### Documentation From 8092455d1d024a546230815957da49996f642b68 Mon Sep 17 00:00:00 2001 From: Alex Page Date: Wed, 10 Mar 2021 16:46:24 -0800 Subject: [PATCH 3/6] Update the accessibility check to use the shared package --- package.json | 2 - scripts/accessibility-check.js | 110 ++++----------------------------- yarn.lock | 2 +- 3 files changed, 12 insertions(+), 102 deletions(-) diff --git a/package.json b/package.json index 546841ddad4..9e3f51544a8 100644 --- a/package.json +++ b/package.json @@ -143,10 +143,8 @@ "node-sass": "^4.12.0", "npm-run-all": "^4.1.5", "object-hash": "^1.3.1", - "p-map": "^4.0.0", "postcss": "^7.0.18", "postcss-modules": "^3.1.0", - "puppeteer": "^1.20.0", "react": "^16.9.0", "react-dom": "^16.9.0", "react-is": "^16.9.0", diff --git a/scripts/accessibility-check.js b/scripts/accessibility-check.js index b753703869a..27d5cbd198b 100644 --- a/scripts/accessibility-check.js +++ b/scripts/accessibility-check.js @@ -1,107 +1,19 @@ /* eslint-disable no-console */ -const os = require('os'); - -const puppeteer = require('puppeteer'); -const pMap = require('p-map'); -const chalk = require('chalk'); - -// eslint-disable-next-line node/no-path-concat -const iframePath = `file://${__dirname}/../build/storybook/static/iframe.html`; -const concurrentCount = os.cpus().length; -const skippedStoryIds = ['playground-playground', 'all-examples']; - -const getUrls = async (browser) => { - // Get the URLS from storybook - const page = await browser.newPage(); - await page.goto(iframePath); - const storyIds = await page.evaluate(() => - window.__STORYBOOK_CLIENT_API__.raw().map((story) => story.id), - ); - await page.close(); - - const urls = storyIds.reduce((memo, storyId) => { - // If it is a story id that is not in excludedStoryIds - if (skippedStoryIds.every((id) => !storyId.includes(id))) { - const url = `${iframePath}?id=${storyId}`; - memo.push( - url, - // Dark mode has lots of errors. It is still very WIP so ignore for now - // `${url}&contexts=Color%20scheme%3DDark%20Mode`, - ); - } - - return memo; - }, []); - - return urls; -}; - -const formatFailure = (fail) => { - return ` - ${fail.failureSummary.split('\n ')[1]}\n ${fail.html}`; -}; - -const formatMessage = (id, violations) => { - const url = chalk.underline.blue( - `http://localhost:6006/iframe.html?id=all-components-${id}`, - ); - return violations - .map((fail) => { - const message = fail.nodes - .map((error) => formatFailure(error)) - .join('\n'); - return `${chalk.red(fail.impact)} => ${url}\n${message}`; - }) - .join('\n'); -}; +const {storybookA11yTest} = require('@shopify/storybook-a11y-test'); (async () => { - try { - // Open a browser - console.log(chalk.bold(`๐ŸŒ Opening ${concurrentCount} tabs in chromium`)); - const browser = await puppeteer.launch(); - - // Get the test ids from storybook - const testIds = await getUrls(browser); - - console.log(chalk.bold(`๐Ÿงช Testing ${testIds.length} urls with axe`)); - - // Test the pages with axe - const testPage = async (url) => { - const id = url.replace(`${iframePath}?id=all-components-`, ''); - console.log(` - ${id}`); - - try { - const page = await browser.newPage(); - await page.goto(url); - const result = await page.evaluate(() => - window.axe.run(document.getElementById('root'), {}), - ); - await page.close(); - - if (result.violations.length) { - return formatMessage(id, result.violations); - } - } catch (error) { - return `please retry => ${id}:\n - ${error.message}`; - } - }; + const options = { + iframePath: 'build/storybook/static/iframe.html', + skippedStoryIds: ['playground-playground', 'all-examples'], + }; - const results = await pMap(testIds, testPage, { - concurrency: concurrentCount, - }); - await browser.close(); + const results = await storybookA11yTest(options); - // Format the results and log them out - const messages = results.filter((x) => x); - if (messages.length) { - console.error(chalk.bold(`โ€ผ๏ธ Test failures found`)); - console.log(messages.join('\n')); - process.exit(1); - } else { - console.log(chalk.bold('๐Ÿงšโ€โ™€๏ธ Accessibility is all g')); - } - } catch (error) { - console.error(error.message); + if (results.length) { + console.error(`โ€ผ๏ธ Test failures found`); + console.log(results.join('\n')); process.exit(1); + } else { + console.log('๐Ÿงšโ€โ™€๏ธ Accessibility is all g'); } })(); diff --git a/yarn.lock b/yarn.lock index c48558eddce..479ada45aa9 100644 --- a/yarn.lock +++ b/yarn.lock @@ -16170,7 +16170,7 @@ punycode@^2.1.0, punycode@^2.1.1: resolved "https://registry.yarnpkg.com/punycode/-/punycode-2.1.1.tgz#b58b010ac40c22c5657616c8d2c2c02c7bf479ec" integrity sha512-XRsRjdf+j5ml+y/6GKHPZbrF/8p2Yga0JPtdqTIY2Xe5ohJPD9saDJJLPvp9+NSBprVvevdXZybnj2cv8OEd0A== -puppeteer@^1.20.0, puppeteer@^1.4.0: +puppeteer@^1.4.0: version "1.20.0" resolved "https://registry.yarnpkg.com/puppeteer/-/puppeteer-1.20.0.tgz#e3d267786f74e1d87cf2d15acc59177f471bbe38" integrity sha512-bt48RDBy2eIwZPrkgbcwHtb51mj2nKvHOPMaSH2IsWiv7lOG9k9zhaRzpDZafrk05ajMc3cu+lSQYYOfH2DkVQ== From cfff283db3b026d0aba8b42adfc37ab2d7a791dc Mon Sep 17 00:00:00 2001 From: Dominic McPhee Date: Thu, 11 Mar 2021 17:01:19 -0500 Subject: [PATCH 4/6] Adding package and bumping node version --- .github/workflows/ci.yml | 4 +- .nvmrc | 2 +- dev.yml | 2 +- package.json | 1 + yarn.lock | 112 +++++++++++++++++++++++++++++++++++++-- 5 files changed, 113 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8a3ddf19d55..48527e16635 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,7 +17,7 @@ jobs: - uses: actions/setup-node@v2 with: - node-version: '10.15.0' + node-version: '10.24.0' - name: Get yarn cache directory path id: yarn-cache-dir-path @@ -73,7 +73,7 @@ jobs: - uses: actions/setup-node@v2 with: - node-version: '10.15.0' + node-version: '10.24.0' - name: Get yarn cache directory path id: yarn-cache-dir-path diff --git a/.nvmrc b/.nvmrc index 65466b83f74..e3653a9a7e9 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -v10.15.0 +v10.24.0 diff --git a/dev.yml b/dev.yml index 114911ff75e..154ed60b2cb 100644 --- a/dev.yml +++ b/dev.yml @@ -2,7 +2,7 @@ name: polaris-react up: - node: yarn: v1.13.0 - version: v10.15.0 # to be kept in sync with .nvmrc and ci.yml + version: v10.24.0 # to be kept in sync with .nvmrc and ci.yml - git_hooks: pre-commit: pre-commit diff --git a/package.json b/package.json index 9e3f51544a8..3d6e162ccbb 100644 --- a/package.json +++ b/package.json @@ -110,6 +110,7 @@ "@shopify/sewing-kit": "^0.140.0", "@shopify/shrink-ray": "^2.3.1", "@shopify/splash": "^0.0.8", + "@shopify/storybook-a11y-test": "^0.0.1", "@storybook/addon-a11y": "^6.1.11", "@storybook/addon-console": "^1.2.1", "@storybook/addon-contexts": "^5.3.19", diff --git a/yarn.lock b/yarn.lock index 479ada45aa9..91b4d7d617a 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2844,6 +2844,16 @@ rollup-plugin-typescript2 "^0.25.2" typescript "^3.7.2" +"@shopify/storybook-a11y-test@^0.0.1": + version "0.0.1" + resolved "https://registry.yarnpkg.com/@shopify/storybook-a11y-test/-/storybook-a11y-test-0.0.1.tgz#a451fe4f03701017aaa98e3786af9a87f51bc9b1" + integrity sha512-7ChNvDryqwgitNEQUn0UKqiLyA+SQYI59rcN8jjorfNOR58dlZ/Z75LDIAo9nh1xG1mLsDx6SQdr0H8xAnb8XA== + dependencies: + chalk "^4.1.0" + p-map "^4.0.0" + puppeteer "^7.1.0" + tslib "^1.14.1" + "@shopify/stylelint-plugin@^10.0.1": version "10.0.1" resolved "https://registry.yarnpkg.com/@shopify/stylelint-plugin/-/stylelint-plugin-10.0.1.tgz#06199fb65a8612b2ba87888c62952bf8cbcbf746" @@ -4367,6 +4377,13 @@ dependencies: "@types/yargs-parser" "*" +"@types/yauzl@^2.9.1": + version "2.9.1" + resolved "https://registry.yarnpkg.com/@types/yauzl/-/yauzl-2.9.1.tgz#d10f69f9f522eef3cf98e30afb684a1e1ec923af" + integrity sha512-A1b8SU4D10uoPjwb0lnHmmu8wZhR9d+9o2PKBQT2jU5YPTKsxac6M2qGAdY7VcL+dHHhARVUDmeg0rOrcd9EjA== + dependencies: + "@types/node" "*" + "@typescript-eslint/eslint-plugin@^4.1.0": version "4.6.0" resolved "https://registry.yarnpkg.com/@typescript-eslint/eslint-plugin/-/eslint-plugin-4.6.0.tgz#210cd538bb703f883aff81d3996961f5dba31fdb" @@ -5990,6 +6007,15 @@ bl@^1.0.0: readable-stream "^2.3.5" safe-buffer "^5.1.1" +bl@^4.0.3: + version "4.1.0" + resolved "https://registry.yarnpkg.com/bl/-/bl-4.1.0.tgz#451535264182bec2fbbc83a62ab98cf11d9f7b3a" + integrity sha512-1W07cM9gS6DcLperZfFSj+bWLtaPGSOHWhPiGzXmvVJbRLdG82sH/Kn8EtW1VqWVA54AKf2h5k5BbnIbwF3h6w== + dependencies: + buffer "^5.5.0" + inherits "^2.0.4" + readable-stream "^3.4.0" + block-stream@*: version "0.0.9" resolved "https://registry.yarnpkg.com/block-stream/-/block-stream-0.0.9.tgz#13ebfe778a03205cfe03751481ebb4b3300c126a" @@ -6299,6 +6325,14 @@ buffer@^5.2.1: base64-js "^1.3.1" ieee754 "^1.1.13" +buffer@^5.5.0: + version "5.7.1" + resolved "https://registry.yarnpkg.com/buffer/-/buffer-5.7.1.tgz#ba62e7c13133053582197160851a8f648e99eed0" + integrity sha512-EHcyIPBQ4BSGlvjB16k5KgAJ27CIsHY/2JBmCRReo48y9rQ3MaUzWX3KVlBa4U7MyX02HdVj0K7C3WaB3ju7FQ== + dependencies: + base64-js "^1.3.1" + ieee754 "^1.1.13" + bufferutil@^4.0.1: version "4.0.1" resolved "https://registry.yarnpkg.com/bufferutil/-/bufferutil-4.0.1.tgz#3a177e8e5819a1243fe16b63a199951a7ad8d4a7" @@ -8085,6 +8119,11 @@ detect-port@^1.3.0: address "^1.0.1" debug "^2.6.0" +devtools-protocol@0.0.847576: + version "0.0.847576" + resolved "https://registry.yarnpkg.com/devtools-protocol/-/devtools-protocol-0.0.847576.tgz#2f201bfb68aa9ef4497199fbd7f5d5dfde3b200b" + integrity sha512-0M8kobnSQE0Jmly7Mhbeq0W/PpZfnuK+WjN2ZRVPbGqYwCHCioAVp84H0TcLimgECcN5H976y5QiXMGBC9JKmg== + diff-sequences@^25.2.6: version "25.2.6" resolved "https://registry.yarnpkg.com/diff-sequences/-/diff-sequences-25.2.6.tgz#5f467c00edd35352b7bca46d7927d60e687a76dd" @@ -9368,6 +9407,17 @@ extract-zip@^1.6.6: mkdirp "0.5.1" yauzl "2.4.1" +extract-zip@^2.0.0: + version "2.0.1" + resolved "https://registry.yarnpkg.com/extract-zip/-/extract-zip-2.0.1.tgz#663dca56fe46df890d5f131ef4a06d22bb8ba13a" + integrity sha512-GDhU9ntwuKyGXdZBUgTIe+vXnWj0fppUEtMDL0+idd5Sta8TGpHssn/eusA9mrPr9qNDym6SxAYZjNvCn/9RBg== + dependencies: + debug "^4.1.1" + get-stream "^5.1.0" + yauzl "^2.10.0" + optionalDependencies: + "@types/yauzl" "^2.9.1" + extsprintf@1.3.0, extsprintf@^1.2.0: version "1.3.0" resolved "https://registry.yarnpkg.com/extsprintf/-/extsprintf-1.3.0.tgz#96918440e3041a7a414f8c52e3c574eb3c3e1e05" @@ -11430,7 +11480,7 @@ inherits@2.0.1: resolved "https://registry.yarnpkg.com/inherits/-/inherits-2.0.1.tgz#b17d08d326b4423e568eff719f91b0b1cbdf69f1" integrity sha1-sX0I0ya0Qj5Wjv9xn5GwscvfafE= -inherits@2.0.4: +inherits@2.0.4, inherits@^2.0.4: version "2.0.4" resolved "https://registry.yarnpkg.com/inherits/-/inherits-2.0.4.tgz#0fa2c64f932917c3433a0ded55363aae37416b7c" integrity sha512-k/vGaX4/Yla3WzyMCvTQOXYeIHvqOKtnqBduzTHpzpQZzAskKMhZ2K+EnBiSM9zGSoIFeMpXKxa4dYeZIQqewQ== @@ -13986,6 +14036,11 @@ mixin-object@^2.0.1: for-in "^0.1.3" is-extendable "^0.1.1" +mkdirp-classic@^0.5.2: + version "0.5.3" + resolved "https://registry.yarnpkg.com/mkdirp-classic/-/mkdirp-classic-0.5.3.tgz#fa10c9115cc6d8865be221ba47ee9bed78601113" + integrity sha512-gKLcREMhtuZRwRAfqP3RFW+TK4JqApVBtOIftVgjuABpAtpxhPGaDcfvbhNvD0B8iD1oUr/txX35NjcaY6Ns/A== + mkdirp@0.5.1: version "0.5.1" resolved "https://registry.yarnpkg.com/mkdirp/-/mkdirp-0.5.1.tgz#30057438eac6cf7f8c4767f38648d6697d75c903" @@ -16095,6 +16150,11 @@ proxy-from-env@^1.0.0: resolved "https://registry.yarnpkg.com/proxy-from-env/-/proxy-from-env-1.0.0.tgz#33c50398f70ea7eb96d21f7b817630a55791c7ee" integrity sha1-M8UDmPcOp+uW0h97gXYwpVeRx+4= +proxy-from-env@^1.1.0: + version "1.1.0" + resolved "https://registry.yarnpkg.com/proxy-from-env/-/proxy-from-env-1.1.0.tgz#e102f16ca355424865755d2c9e8ea4f24d58c3e2" + integrity sha512-D+zkORCbA9f1tdWRK0RaCR3GPv50cMxcrz4X8k5LTSUD1Dkw47mKJEZQNunItRTkWwgtaUSo1RVFRIG9ZXiFYg== + prr@~1.0.1: version "1.0.1" resolved "https://registry.yarnpkg.com/prr/-/prr-1.0.1.tgz#d3fc114ba06995a45ec6893f484ceb1d78f5f476" @@ -16184,6 +16244,24 @@ puppeteer@^1.4.0: rimraf "^2.6.1" ws "^6.1.0" +puppeteer@^7.1.0: + version "7.1.0" + resolved "https://registry.yarnpkg.com/puppeteer/-/puppeteer-7.1.0.tgz#ae37f48ee13f157c5b9255d580ffe4c5c1298679" + integrity sha512-lqOLzqCKdh7yUAHvK6LxgOpQrL8Bv1/jvS8MLDXxcNms2rlM3E8p/Wlwc7efbRZ0twxTzUeqjN5EqrTwxOwc9g== + dependencies: + debug "^4.1.0" + devtools-protocol "0.0.847576" + extract-zip "^2.0.0" + https-proxy-agent "^5.0.0" + node-fetch "^2.6.1" + pkg-dir "^4.2.0" + progress "^2.0.1" + proxy-from-env "^1.1.0" + rimraf "^3.0.2" + tar-fs "^2.0.0" + unbzip2-stream "^1.3.3" + ws "^7.2.3" + q@^1.1.2: version "1.5.1" resolved "https://registry.yarnpkg.com/q/-/q-1.5.1.tgz#7e32f75b41381291d04611f1bf14109ac00651d7" @@ -16750,7 +16828,7 @@ read-pkg@^5.2.0: string_decoder "~1.1.1" util-deprecate "~1.0.1" -readable-stream@^3.0.6, readable-stream@^3.1.1: +readable-stream@^3.0.6, readable-stream@^3.1.1, readable-stream@^3.4.0: version "3.6.0" resolved "https://registry.yarnpkg.com/readable-stream/-/readable-stream-3.6.0.tgz#337bbda3adc0706bd3e024426a286d4b4b2c9198" integrity sha512-BViHy7LKeTz4oNnkcLJ+lVSL6vpiFeX6/d3oSH8zCW7UxP2onchk+vTGB143xuFjHS3deTgkKoXXymXqymiIdA== @@ -18899,6 +18977,16 @@ tapable@^1.0.0, tapable@^1.1.3: resolved "https://registry.yarnpkg.com/tapable/-/tapable-1.1.3.tgz#a1fccc06b58db61fd7a45da2da44f5f3a3e67ba2" integrity sha512-4WK/bYZmj8xLr+HUCODHGF1ZFzsYffasLUgEiMBY4fgtltdO6B4WJtlSbPaDTLpYTcGVwM2qLnFTICEcNxs3kA== +tar-fs@^2.0.0: + version "2.1.1" + resolved "https://registry.yarnpkg.com/tar-fs/-/tar-fs-2.1.1.tgz#489a15ab85f1f0befabb370b7de4f9eb5cbe8784" + integrity sha512-V0r2Y9scmbDRLCNex/+hYzvp/zyYjvFbHPNgVTKfQvVrb6guiE/fxP+XblDNR011utopbkex2nM4dHNV6GDsng== + dependencies: + chownr "^1.1.1" + mkdirp-classic "^0.5.2" + pump "^3.0.0" + tar-stream "^2.1.4" + tar-stream@^1.5.2: version "1.6.2" resolved "https://registry.yarnpkg.com/tar-stream/-/tar-stream-1.6.2.tgz#8ea55dab37972253d9a9af90fdcd559ae435c555" @@ -18912,6 +19000,17 @@ tar-stream@^1.5.2: to-buffer "^1.1.1" xtend "^4.0.0" +tar-stream@^2.1.4: + version "2.2.0" + resolved "https://registry.yarnpkg.com/tar-stream/-/tar-stream-2.2.0.tgz#acad84c284136b060dc3faa64474aa9aebd77287" + integrity sha512-ujeqbceABgwMZxEJnk2HDY2DlnUZ+9oEcb1KzTVfYHio0UE6dG71n60d8D2I4qNvleWrrXpmjpt7vZeF1LnMZQ== + dependencies: + bl "^4.0.3" + end-of-stream "^1.4.1" + fs-constants "^1.0.0" + inherits "^2.0.3" + readable-stream "^3.1.1" + tar@^2.0.0: version "2.2.2" resolved "https://registry.yarnpkg.com/tar/-/tar-2.2.2.tgz#0ca8848562c7299b8b446ff6a4d60cdbb23edc40" @@ -19498,7 +19597,7 @@ typescript@~4.0.3: resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.0.3.tgz#153bbd468ef07725c1df9c77e8b453f8d36abba5" integrity sha512-tEu6DGxGgRJPb/mVPIZ48e69xCn2yRmCgYmDugAVwmJ6o+0u1RI18eO7E7WBTLYLaEVVOhwQmcdhQHweux/WPg== -unbzip2-stream@^1.0.9: +unbzip2-stream@^1.0.9, unbzip2-stream@^1.3.3: version "1.4.3" resolved "https://registry.yarnpkg.com/unbzip2-stream/-/unbzip2-stream-1.4.3.tgz#b0da04c4371311df771cdc215e87f2130991ace7" integrity sha512-mlExGW4w71ebDJviH16lQLtZS32VKqsSfk80GCfUlwT/4/hNRFsoscrF/c++9xinkMzECL1uL9DDwXqFWkruPg== @@ -20522,6 +20621,11 @@ ws@^7.0.0: resolved "https://registry.yarnpkg.com/ws/-/ws-7.3.0.tgz#4b2f7f219b3d3737bc1a2fbf145d825b94d38ffd" integrity sha512-iFtXzngZVXPGgpTlP1rBqsUK82p9tKqsWRPg5L56egiljujJT3vGAYnHANvFxBieXrTFavhzhxW52jnaWV+w2w== +ws@^7.2.3: + version "7.4.4" + resolved "https://registry.yarnpkg.com/ws/-/ws-7.4.4.tgz#383bc9742cb202292c9077ceab6f6047b17f2d59" + integrity sha512-Qm8k8ojNQIMx7S+Zp8u/uHOx7Qazv3Yv4q68MiWWWOJhiwG5W3x7iqmRtJo8xxrciZUY4vRxUTJCKuRnF28ZZw== + xdg-basedir@^4.0.0: version "4.0.0" resolved "https://registry.yarnpkg.com/xdg-basedir/-/xdg-basedir-4.0.0.tgz#4bc8d9984403696225ef83a1573cbbcb4e79db13" @@ -20676,7 +20780,7 @@ yauzl@2.4.1: dependencies: fd-slicer "~1.0.1" -yauzl@^2.4.2: +yauzl@^2.10.0, yauzl@^2.4.2: version "2.10.0" resolved "https://registry.yarnpkg.com/yauzl/-/yauzl-2.10.0.tgz#c7eb17c93e112cb1086fa6d8e51fb0667b79a5f9" integrity sha1-x+sXyT4RLLEIb6bY5R+wZnt5pfk= From 6bcd1dbd7b80ecbb9bd38589a0da794b2e1d6f76 Mon Sep 17 00:00:00 2001 From: Dominic McPhee Date: Thu, 11 Mar 2021 17:04:09 -0500 Subject: [PATCH 5/6] Bump node version in workflows --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 48527e16635..fa98dc92b89 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -45,7 +45,7 @@ jobs: - uses: actions/setup-node@v2 with: - node-version: '10.15.0' + node-version: '10.24.0' - name: Get yarn cache directory path id: yarn-cache-dir-path @@ -104,7 +104,7 @@ jobs: - uses: actions/setup-node@v2 with: - node-version: '10.15.0' + node-version: '10.24.0' - name: Get yarn cache directory path id: yarn-cache-dir-path From 3dd44717b8b744f113103c35b49d3489d4436e4a Mon Sep 17 00:00:00 2001 From: Dominic McPhee Date: Thu, 11 Mar 2021 17:23:18 -0500 Subject: [PATCH 6/6] Fix iframe path --- scripts/accessibility-check.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/scripts/accessibility-check.js b/scripts/accessibility-check.js index 27d5cbd198b..8869adc0689 100644 --- a/scripts/accessibility-check.js +++ b/scripts/accessibility-check.js @@ -1,9 +1,15 @@ /* eslint-disable no-console */ +const path = require('path'); + const {storybookA11yTest} = require('@shopify/storybook-a11y-test'); (async () => { const options = { - iframePath: 'build/storybook/static/iframe.html', + iframePath: path.join( + 'file://', + __dirname, + '../build/storybook/static/iframe.html', + ), skippedStoryIds: ['playground-playground', 'all-examples'], };