Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split up replace-border-declarations migration #7599

Closed
4 tasks done
Tracked by #7477
chloerice opened this issue Nov 1, 2022 · 0 comments · Fixed by #7606
Closed
4 tasks done
Tracked by #7477

Split up replace-border-declarations migration #7599

chloerice opened this issue Nov 1, 2022 · 0 comments · Fixed by #7606
Assignees
@chloerice

Comments

@chloerice
Copy link
Member

chloerice commented Nov 1, 2022 •
edited by sam-b-rose
Loading

Right now, the replace-border-declarations migration encompasses both length migration (px/rem => tokens) and legacy Sass migration (border-radius(large) => token). Using the conventions we aligned on in this discussion, let's split up this migration into smaller migrations scoped to Sass or static styles:

  • sass-replace-border
  • sass-replace-border-radius
  • sass-replace-border-width
  • styles-tokenize-shape
@chloerice chloerice self-assigned this Nov 1, 2022
@chloerice chloerice changed the title Split up replace-border-declarations migration using aligned naming, scope and structure Split up replace-border-declarations migration Nov 1, 2022
@sam-b-rose sam-b-rose mentioned this issue Nov 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chloerice chloerice

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renaming and splitting of migrations to new convention Shopify/polaris
1 participant
@chloerice