From 53206c77e6112e3979cdc06e3a69c776270a16ec Mon Sep 17 00:00:00 2001 From: Daniel Leroux Date: Tue, 19 Nov 2019 09:20:08 -0500 Subject: [PATCH] prevent tabbing to hidden submit --- UNRELEASED.md | 1 + src/components/Form/Form.tsx | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/UNRELEASED.md b/UNRELEASED.md index 017db5e272f..13a049c1137 100644 --- a/UNRELEASED.md +++ b/UNRELEASED.md @@ -7,6 +7,7 @@ - Added `external` prop to `ResourceList` ([#2408](https://github.com/Shopify/polaris-react/pull/2408)) - Added `onMouseEnter` and `onTouchStart` props to `Button` ([#2409](https://github.com/Shopify/polaris-react/pull/2409)) - Added `ariaHaspopup` prop to `Popover` ([#2248](https://github.com/Shopify/polaris-react/pull/2248)) +- Fixed an accessibility issue where the `Form` implicit submit was still accessible via keyboard ([#2447](https://github.com/Shopify/polaris-react/pull/2447)) ### Bug fixes diff --git a/src/components/Form/Form.tsx b/src/components/Form/Form.tsx index f9f7cc6f956..6d5e718656f 100644 --- a/src/components/Form/Form.tsx +++ b/src/components/Form/Form.tsx @@ -71,7 +71,7 @@ export function Form({ const submitMarkup = implicitSubmit ? ( -