Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix safe area for mixin with fallback #881

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

danrosenthal
Copy link
Contributor

No description provided.

@BPScott BPScott temporarily deployed to polaris-react-pr-881 January 16, 2019 16:58 Inactive
Copy link
Member

@lemonmade lemonmade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to put this one above the calcs so that if they are supported, they will take precedence. Otherwise looks good

@danrosenthal danrosenthal force-pushed the fix-safe-area-for-mixin-with-fallback branch from 6c28431 to 02e7776 Compare January 16, 2019 17:40
@BPScott BPScott temporarily deployed to polaris-react-pr-881 January 16, 2019 17:40 Inactive
Copy link
Member

@lemonmade lemonmade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we be able to get this in a patch that is easy for web to consume?

@danrosenthal
Copy link
Contributor Author

Will we be able to get this in a patch that is easy for web to consume?

This will need to be a minor release because of https://github.com/Shopify/polaris-react/pull/881/files#diff-1f9a24a2e063326eff13af43500f8b74R11 @lemonmade.

@danrosenthal danrosenthal merged commit 5e47062 into master Jan 16, 2019
@danrosenthal danrosenthal deleted the fix-safe-area-for-mixin-with-fallback branch January 16, 2019 17:55
@danrosenthal danrosenthal temporarily deployed to production January 16, 2019 18:10 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants