Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
That extra transpile step means an extra dependency but doesn't add
any value
WHAT is this pull request doing?
babel-node
withnode
.import
lines withrequire()
and replacingexport default
withmodule.exports =
How to 🎩
build and build-consumer
mkdir -p old-build/node_modules/@shopify/polaris-react && yarn run build-consumer polaris-react/old-build
This will create a baseline build to compare againstyarn install
yarn clean && mkdir -p new-build/node_modules/@shopify/polaris-react && yarn run build-consumer polaris-react/new-build
This creates a new builddiff -r -u old-build new-build
to compare the build outputs. The only difference should be within the package.jsonreadme-update-version
3.4.0-rc.1
)yarn run readme-update-version
and see that README file contents have been updatedopen-styleguide-pr
Kinda hard without making a release to test.