Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all usages of babel-node #836

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Remove all usages of babel-node #836

merged 1 commit into from
Jan 9, 2019

Conversation

BPScott
Copy link
Member

@BPScott BPScott commented Jan 8, 2019

WHY are these changes introduced?

That extra transpile step means an extra dependency but doesn't add
any value

WHAT is this pull request doing?

  • Replaces all calls to babel-node with node.
  • Removes the dependency on babel-cli
  • Updates all scripts so they work with plain node. This boiled down to replacing import lines with require() and replacing export default with module.exports =

How to 🎩

build and build-consumer

  • Check out master branch
  • Run mkdir -p old-build/node_modules/@shopify/polaris-react && yarn run build-consumer polaris-react/old-build This will create a baseline build to compare against
  • Checkout this branch and yarn install
  • Run yarn clean && mkdir -p new-build/node_modules/@shopify/polaris-react && yarn run build-consumer polaris-react/new-build This creates a new build
  • Run diff -r -u old-build new-build to compare the build outputs. The only difference should be within the package.json

readme-update-version

  • Modify the version in package.json (e.g change it to 3.4.0-rc.1)
  • Run yarn run readme-update-version and see that README file contents have been updated

open-styleguide-pr

Kinda hard without making a release to test.

@BPScott BPScott temporarily deployed to polaris-react-pr-836 January 8, 2019 23:35 Inactive
Copy link
Contributor

@tmlayton tmlayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust that you tested this per the 🎩 instructions, otherwise code looks good. We have tests for the build scripts and the readme script, too.

Could you add a changelog entry just as a safety measure to provide more visibility around this change?

That extra transpile step means an extra dependency but doesn't add
any value
@BPScott
Copy link
Member Author

BPScott commented Jan 9, 2019

Rebased to include a changelog entry 👍

@BPScott BPScott temporarily deployed to beta January 10, 2019 20:44 Inactive
@kaelig kaelig deployed to test-yarn-npx January 11, 2019 00:53 Active
@danrosenthal danrosenthal temporarily deployed to production January 16, 2019 18:10 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants