-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Page] print mode adjustments #2469
Conversation
💦 Potential splash zone of changes introduced to
DetailsAll files potentially affected (total: 2)📄
|
eef862a
to
c8661d8
Compare
@@ -9,6 +9,7 @@ | |||
- Added `ariaHaspopup` prop to `Popover` ([#2248](https://github.com/Shopify/polaris-react/pull/2248)) | |||
- Fixed an accessibility issue where the `Form` implicit submit was still accessible via keyboard ([#2447](https://github.com/Shopify/polaris-react/pull/2447)) | |||
- Moved `Button` styles from the `Buttongroup` CSS file to the `Button` CSS file ([#2441](https://github.com/Shopify/polaris-react/pull/2441)) | |||
- `Page` no longer renders navigation or actions in print mode ([#2469](https://github.com/Shopify/polaris-react/pull/2469)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we consider this a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd consider it a bug fix, as I think that you're right about this being expected behavior. @kaelig do you have an opinion on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎩 Looks good 👍 🚀
c8661d8
to
4e55853
Compare
WHY are these changes introduced?
When printing a page, we don't want the breadcrumbs or actions to be visible.
WHAT is this pull request doing?
removing actions and breadcrumbs from Page header in print mode using the
print
media query mixin.How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Run the playground below and click the
Print
action to view the print mode page without any nav or actions.Copy-paste this code in
playground/Playground.tsx
:🎩 checklist
README.md
with documentation changes