Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextField] Replaced setMounted with custom hook #2464

Merged
merged 2 commits into from
Nov 28, 2019
Merged

[TextField] Replaced setMounted with custom hook #2464

merged 2 commits into from
Nov 28, 2019

Conversation

AndrewMusgrave
Copy link
Member

WHY are these changes introduced?

Using one of our fancy hooks

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2019 •
edited
Loading

💦 Potential splash zone of changes introduced to src/**/*.tsx in this pull request:

Files modified2
Files potentially affected9

Details

All files potentially affected (total: 9)
📄 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

🧩 src/components/TextField/TextField.tsx (total: 9)

Files potentially affected (total: 9)

This comment automatically updates as changes are made to this pull request.
Feedback, troubleshooting: open an issue or reach out on Slack in #polaris-tooling.

dleroux
dleroux approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@dleroux dleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fancy hook 🎉

@AndrewMusgrave AndrewMusgrave merged commit 1923690 into master Nov 28, 2019
@AndrewMusgrave AndrewMusgrave deleted the replace-set-mounted branch November 28, 2019 16:44
@dleroux dleroux temporarily deployed to production December 4, 2019 14:42 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dleroux dleroux dleroux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndrewMusgrave @dleroux