Removing z-index on icons #2207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Currently we apply a z-index to icons to allow for them to sit above the backdrop when using one. This causes strange issues in consumers because it means icons get an arbitrary z-index of 2, lifting them over things that they shouldn't be.
WHAT is this pull request doing?
This removes the z-indexes and instead changes the
::afterused for the backdrop to be a::beforewhich naturally stacks correctly without a z-index.How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Ideally any regressions here will be caught by percy, but poking around in the playground to see if you can find any holes in this approach would be useful.
🎩 checklist
README.mdwith documentation changes