have to_json and as_json return amount and currency json #138
Conversation
lib/money/money.rb
Outdated
| end | ||
|
|
||
| def as_json(*args) | ||
| to_s | ||
| to_json |
There was a problem hiding this comment.
This should have the actual implementation.
There was a problem hiding this comment.
this was always wrong too, as_json needs to return a hash, not a string... fixed now
|
DO NOT MERGE... until background jobs can handle the new format |
|
this is ready to merge now since https://github.com/Shopify/shopify/pull/151350 |
| def as_json(*args) | ||
| to_s | ||
| def as_json(*_args) | ||
| { value: to_s(:amount), currency: currency.to_s } |
There was a problem hiding this comment.
Should we prefer currency.iso_code here instead to be a bit more clear and future proof if we want to_s to be more human readable?
There was a problem hiding this comment.
the main difference is with a NullCurrency, to_s will return an empty string, vs iso_code will return XXX. I'd rather keep it the way it is for now since the generated JSON might be sent to a third party which does not understand the valid "no currency" iso code.
|
😮 |
|
this is the new default behaviour in v1.0, with an option to fallback to the legacy behaviour |
Why
Fixes #76
What
as_jsonshould return a hash of attributes (amount, currency) to be serialized, not a stringfrom_jsonis missing to assign attributes from a JSON object