This repository has been archived by the owner on Oct 30, 2024. It is now read-only.
Add command to run ALL the audits #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyhelix
changed the title
jinankjain
previously approved these changes
Jan 10, 2018
klautcomputing
suggested changes
Jan 10, 2018
| @@ -60,9 +60,6 @@ func auditImages(image imgFlags, resource k8sRuntime.Object) (results []Result) | |||
| break | |||
| } | |||
| } | |||
| for _, result := range results { | |||
fixtures/audit_all.yml
Outdated
| kind: Deployment | ||
| metadata: | ||
| creationTimestamp: null | ||
| name: cababilitiesAdded |
There was a problem hiding this comment.
cababilitiesAdded and no caps added 😢
README.md
Outdated
| @@ -265,6 +266,19 @@ WARN[0000] CPU limit exceeded, it is set to 1 but it must not exceed 500m. Pleas | |||
| WARN[0000] Memory limit exceeded, it is set to 512Mi but it must not exceed 125Mi. Please adjust it! | |||
| ``` | |||
|
|
|||
| <a name="all" /> | |||
|
|
|||
There was a problem hiding this comment.
This is a great feature and I think will be the audit that 99% of all the people will run 99% of the time. Thus, it needs to be above all other audits, right next to autofix
skyhelix
changed the title
|
@klautcomputing @fedorlis This can also be merged now :) |
klautcomputing
approved these changes
Jan 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
allcommand, does what it says on the tin.