Skip to content
This repository has been archived by the owner on Oct 30, 2024. It is now read-only.

--auditConfig --> --auditconfig in docs #221

Merged
merged 1 commit into from
Sep 10, 2019
Merged

--auditConfig --> --auditconfig in docs #221

merged 1 commit into from
Sep 10, 2019

Conversation

sulunemre
Copy link
Contributor

Description

Command line argument --auditconfig was wrong in docs

Type of change
  • Bug fix 🐛
  • New feature ✨
  • This change requires a documentation update 📖
  • Breaking changes ⚠️
How Has This Been Tested?
  • Test A
  • Test B
Checklist:
  • I have 🎩 my changes (A 🎩 specifically includes pulling down changes, setting them up, and manually testing the changed features and potential side effects to make sure nothing is broken)
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The test coverage did not decrease

@ghost
Copy link

ghost commented Aug 20, 2019

Thanks for opening this pull request! Please check out our contributing guidelines and sign the CLA.

@sulunemre sulunemre changed the title --auditConfig ---> --auditconfig in docs --auditConfig --> --auditconfig in docs Aug 20, 2019
@nschhina
Copy link
Contributor

LGTM, @genevieveluyt please re-run CLA test and merge if all green

@ghost ghost removed the cla-needed label Sep 10, 2019
genevieveluyt
genevieveluyt approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@genevieveluyt genevieveluyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@genevieveluyt genevieveluyt merged commit 019bf4a into Shopify:master Sep 10, 2019
@ghost
Copy link

ghost commented Sep 10, 2019

Congrats on merging your first pull request, keep em coming!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@genevieveluyt genevieveluyt genevieveluyt approved these changes

@nschhina nschhina nschhina approved these changes

Assignees
No one assigned
Labels
readme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sulunemre @nschhina @genevieveluyt