Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CartProvider]: Add requirement that it must be a descendant of ShopifyProvider #744

Merged
merged 4 commits into from
Apr 3, 2023
Merged

[CartProvider]: Add requirement that it must be a descendant of ShopifyProvider #744

merged 4 commits into from
Apr 3, 2023

Conversation

mcvinci
Copy link
Contributor

@mcvinci mcvinci commented Mar 31, 2023

This PR:

@github-actions
Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset.
If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.

@mcvinci mcvinci self-assigned this Mar 31, 2023
@mcvinci mcvinci requested a review from lordofthecactus March 31, 2023 15:22
notoriousP
notoriousP approved these changes Apr 3, 2023
View reviewed changes
Copy link

@notoriousP notoriousP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@frehner
Copy link
Contributor

frehner commented Apr 3, 2023

I think you need to run generate-docs one more time with that latest update, and then we're good to go!

@mcvinci mcvinci merged commit 92ca75b into 2023-01 Apr 3, 2023
@mcvinci mcvinci deleted the cartprovider-requirement branch April 3, 2023 19:22
@frehner frehner mentioned this pull request Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frehner frehner frehner left review comments

@notoriousP notoriousP notoriousP approved these changes

@lordofthecactus lordofthecactus Awaiting requested review from lordofthecactus

Assignees

@mcvinci mcvinci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcvinci @frehner @notoriousP