Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create devcontainer.json #661

Closed
wants to merge 1 commit into from

Conversation

rafaelstz
Copy link
Contributor

WHY are these changes introduced?

It introduces dev container to the demo store to make it easier to use.

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@blittle
Copy link
Contributor

blittle commented Mar 14, 2023

Hi @rafaelstz, thank you for the PR. Can you explain to us the benefits of having this in the repo itself, instead of someone using devcontainers just adding their own devcontainer config?

@blittle blittle closed this Mar 20, 2023
@rafaelstz
Copy link
Contributor Author

Hi @blittle, this would take less time to start the project using VSCode or Github CodeSpaces. Since we have the minimum requirements to run Hydrogen, having the standard setup created would avoid issues with the environment to start testing it.
It wouldn't avoid customizations too, as same as .gitignore file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants