Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix init error for internal shopifolk #658

Closed
wants to merge 1 commit into from

Conversation

cartogram
Copy link
Contributor

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@frandiox
Copy link
Contributor

frandiox commented Mar 8, 2023

I might be wrong but I think the actual issue happens when installing the CLI itself:

npm create @shopify/hydrogen@latest
Need to install the following packages:
  @shopify/[email protected]
Ok to proceed? (y)
npm ERR! code ETARGET
npm ERR! code notarget No matching version found for @shopify/oxygen-workers-types@^3.17.2

Therefore I don't think there's a chance for the code in this PR to run, right?

@cartogram
Copy link
Contributor Author

@frandiox oh I think you are right! I was assuming folks were blocked by the installDeps step and remembered we had something like this on hydrogen 1. Maybe some preinstall script would work here, but haven't actually dug into it enough. This was just a quick POC from some discussion in slack.

Will close for now. Thanks for the 👀

@cartogram cartogram closed this Mar 8, 2023
@marcelobarreto
Copy link
Member

I just got this problem when tried to run npm create @shopify/hydrogen@latest

And got something like from my logs:

4469 verbose stack @shopify/oxygen-workers-types: No matching version found for @shopify/oxygen-workers-types@^3.17.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants