Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate script params and command params #564

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Separate script params and command params #564

merged 1 commit into from
Feb 24, 2023

Conversation

jonasnobile
Copy link
Contributor

@jonasnobile jonasnobile commented Feb 21, 2023

create script doesn't work without extra -- which separates script and command params

WHY are these changes introduced?

I was not able to correctly execute npm create script.

WHAT is this pull request doing?

This pull request adds missing -- separator to allow npm script reads its params

@jonasnobile jonasnobile marked this pull request as ready for review February 21, 2023 22:07
@jonasnobile jonasnobile changed the title docs(templates): separate script params and command params Separate script params and command params Feb 21, 2023
create script doesn't work without extra -- which separates script and command params

wip

Re-run actions
Copy link
Contributor

@jplhomer jplhomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Huge bummer that this is necessary 😢

@jplhomer jplhomer merged commit 5530e6c into Shopify:2023-01 Feb 24, 2023
@jonasnobile
Copy link
Contributor Author

You're welcome. Yes, it's extremely enjoying. Hope NPM will fix it some day.

@jonasnobile jonasnobile deleted the patch-1 branch February 24, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants