TS stuff #257
Closed
TS stuff #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frehner
commented
Nov 29, 2022
| @@ -11,6 +12,27 @@ import invariant from 'tiny-invariant'; | |||
| export async function loader({request, context: {storefront}}: LoaderArgs) { | |||
| const url = new URL(request.url); | |||
|
|
|||
| const data = await getAnalyticDataByPageType({ | |||
There was a problem hiding this comment.
data, data2, and data3 should all be correctly typed. So, at least for users of this function, it should "just work".
frehner
commented
Nov 29, 2022
| pageType: string; | ||
| payload: unknown; | ||
| pageType: T; | ||
| payload: PageToPayloadMap[T]; |
There was a problem hiding this comment.
For some reason TS can't figure this out, so you have to cast (as noted in the comments below)
frehner
commented
Nov 29, 2022
| storefront: LoaderArgs['context']['storefront']; | ||
| queries: AnalyticsQueries; | ||
| }) { | ||
| }): Promise<PageToPayloadMap[T]> { |
There was a problem hiding this comment.
And yet, TS can figure this one out. So 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is as good as I can get it I think. There is some manual casting you have to do inside of
getAnalyticDataByPageType, but users of it don't have to do any. 🤷