Add example of (and fix) static asset proxy #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frehner
approved these changes
Nov 29, 2022
templates/demo-store/oxygen.ts
Outdated
| * If you need to serve static assets from the same domain or from the root, | ||
| * update the `shouldProxyAsset: (url: string) => boolean` function below | ||
| * to return `true` when the url (pathname) matches your asset. | ||
| */ |
There was a problem hiding this comment.
Love the comment. Would be nice if we augmented the TS definition for the property so that this shows up when you're using shouldProxyAsset as well, so that it becomes a little piece of documentation for it.
Stretch goal, though.
There was a problem hiding this comment.
Hey why the heck not, right?
jplhomer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a code comment explaining why the
shouldProxyAssetfunction exists and how to use it.Also fixes asset proxying related to an errant
/build/at the beginning of the asset prefix (which is actually a subfolder of/publicassets).