Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General fixes #252

Merged
merged 2 commits into from
Nov 30, 2022
Merged

General fixes #252

merged 2 commits into from
Nov 30, 2022

Conversation

frandiox
Copy link
Contributor

  1. Fix warnings about Image component in terminal
  2. Workaround for hydration issues in browser console

About 2, these are just workarounds that reduce the chance of having a mismatch/Suspense error. I'm not sure if they prevent the issue in all situations though, perhaps there's still some race condition. However, you can compare the following deployments:

After a few refreshes, the deployment in main branch shows minified React error #421, while the other one doesn't (at least not in the 10+ refreshes I've tried).

@frandiox frandiox requested a review from a team November 29, 2022 07:48
@frandiox frandiox merged commit c4e5746 into main Nov 30, 2022
@frandiox frandiox deleted the fd-general-fixes branch November 30, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants