Create PriceRangeFilter component
#208
Conversation
| const location = useLocation(); | ||
|
|
||
| const filterMarkup = (filter: Filter, option: Filter['values'][0]) => { |
There was a problem hiding this comment.
Maybe wrap on useCallback, [] to save some memory
There was a problem hiding this comment.
Do you mean save some re-rendering time? I looked into it a bit after your suggestions. Seems params will change always and re-render will happen anyway. Fixing this will end up making the code complicated. I'd leave this is as it is for now and revisit if necessary.
| return <PriceRangeFilter min={min} max={max} />; | ||
|
|
||
| default: | ||
| const to = getFilterLink( |
There was a problem hiding this comment.
Might want to double check it supports /$lang/ urls too
| if (maxPrice !== '') price.max = maxPrice; | ||
|
|
||
| const newParams = filterInputToParams('PRICE_RANGE', {price}, params); | ||
| window.location.href = `${location.pathname}?${newParams.toString()}`; |
There was a problem hiding this comment.
window.location.href will cause a full render of root loaders and what not. I'd use fetcher.load('updatedUrl') instead
There was a problem hiding this comment.
I'll tackle this in next PR, we are looking to avoid full page reloads
|
Agree, I'm waiting to review of the design by Adam |
Part of #154
This creates a
PriceRangeFilterFeedback I need
PriceRangeFilterbecause of the debouncing, wdyt of this?