Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<Money /> and useMoney example JSDocs #1021

Merged
merged 7 commits into from
Jun 22, 2023
Merged

<Money /> and useMoney example JSDocs #1021

merged 7 commits into from
Jun 22, 2023

Conversation

juanpprieto
Copy link
Contributor

@juanpprieto juanpprieto commented Jun 21, 2023 •
edited
Loading

WHY are these changes introduced?

Hard to remember useful component configurations

WHAT is this pull request doing?

Adds JSDOc examples to <Money /> and useMoney

HOW to test your changes?

Hover docs over these components

<Money />
Screenshot 2023-06-22 at 7 37 49 AM

useMoney

Screenshot 2023-06-22 at 7 37 34 AM

Checklist

@juanpprieto juanpprieto requested a review from a team June 21, 2023 23:02
@juanpprieto juanpprieto marked this pull request as draft June 21, 2023 23:06
@juanpprieto juanpprieto removed the request for review from a team June 21, 2023 23:07
@juanpprieto juanpprieto changed the title Juanpprieto/money exmaple docs <Money /> and useMoney example JSDocs Jun 21, 2023
@juanpprieto juanpprieto marked this pull request as ready for review June 21, 2023 23:25
@juanpprieto juanpprieto requested a review from a team June 21, 2023 23:25
blittle
blittle approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@blittle blittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sooo good!

@juanpprieto juanpprieto merged commit b8f41ad into 2023-04 Jun 22, 2023
@juanpprieto juanpprieto deleted the juanpprieto/money-exmaple-docs branch June 22, 2023 14:39
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Jun 22, 2023
Merged
FrcPpe pushed a commit to FrcPpe/hydrogen that referenced this pull request Aug 13, 2023
@juanpprieto @FrcPpe
<Money /> and useMoney example JSDocs (Shopify#1021)
2070222 
* Add JSDoc examples to <Money />

* Add JSDoc examples to useMoney

* Add JSDoc examples to <Money />

* add changeset

* Fix useMoney JSDocs examples

* Add @link to Money JSDocs

* Add @link to useMoney JSDocs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blittle blittle blittle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juanpprieto @blittle