LAYOUT_QUERY on root.tsx cannot return translated menu items from SFAPI

[natalieoldroyd]

What is the location of your example repository?

https://github.com/natalieoldroyd/c1-demo-hydrogen-h2

Which package or tool is having this issue?

Hydrogen

What version of that package or tool are you using?

2.0

What version of Remix are you using?

No response

Steps to Reproduce

Menu is not supported by the @incontext directive ATM - here’s the list of translatable resources so this query will never return the translated navigation menu items. Since this isn't support by the API unless that changes this query should probably not set the expectation that we can get translated resources in this way.

const LAYOUT_QUERY = `#graphql
  query layoutMenus(
    $language: LanguageCode
    $headerMenuHandle: String!
    $footerMenuHandle: String!
  ) @inContext(language: $language) {
    shop {
      id
      name
      description
    }
    headerMenu: menu(handle: $headerMenuHandle) {
      id
      items {
        ...MenuItem
        items {
          ...MenuItem
        }
      }
    }
    footerMenu: menu(handle: $footerMenuHandle) {
      id
      items {
        ...MenuItem
        items {
          ...MenuItem
        }
      }
    }
  }
  fragment MenuItem on MenuItem {
    id
    resourceId
    tags
    title
    type
    url
  }
`;

Expected Behavior

As of right now the expected behaviour is that we can't get translated menu items even if they are available via translate & adapt app.

Actual Behavior

Translate menu item resources are not returned by the api call.

[frehner]

Thanks for the feedback! This is a known issue, and is being tracked in this repo for the Storefront API: Shopify/storefront-api-feedback#156

[frehner]

(Make sure to give that issue an upvote, as it hopefully signals to the Storefront API team how important it is by the number of upvotes it has received)