Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E localization design #626

Open
elisenyang opened this issue Oct 25, 2022 · 3 comments
Open

E2E localization design #626

elisenyang opened this issue Oct 25, 2022 · 3 comments

Comments

@elisenyang
Copy link
Contributor

We need to figure out how localization works across components (ShopifyProvider, CartProvider, etc.), re-design where it's confusing, and provide docs/tutorials on how to implement and best practices.

Related issues:

@elisenyang elisenyang added the documentation Improvements or additions to documentation label Oct 25, 2022
@rennyG
Copy link
Contributor

rennyG commented Nov 14, 2022

Would this be covered by Hydrogen 2.0 documentation if we're providing a guide on that? cc. @blittle

@elisenyang
Copy link
Contributor Author

elisenyang commented Jan 24, 2023

changes to be made:

  • deprecate shopifyConfig prop (remove from docs)
  • add all props as standalone
  • add countryCode and languageCode props as required and type string
  • don't include locale and make sure to generate this for useMoney

@frehner
Copy link
Contributor

frehner commented Feb 3, 2023

<ShopifyProvider/> has been updated to fit the requirements listed above; the last part of this ticket is to update Cart stuff to make sure it works well with it, too.

@frehner frehner transferred this issue from Shopify/hydrogen-react Mar 3, 2023
@frehner frehner removed their assignment Jun 7, 2023
@michenly michenly added Resource: Docs Needs Docs team and removed documentation Improvements or additions to documentation labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants