Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint v8.x is end of life #2606

Open
tomtuv opened this issue Oct 16, 2024 · 3 comments
Open

ESLint v8.x is end of life #2606

tomtuv opened this issue Oct 16, 2024 · 3 comments
Labels
Bug Something isn't working SEV-3

Comments

@tomtuv
Copy link

tomtuv commented Oct 16, 2024

What is the location of your example repository?

No response

Which package or tool is having this issue?

Hydrogen

What version of that package or tool are you using?

2024.7.9

What version of Remix are you using?

2.10.1

Steps to Reproduce

  1. Create a new Hydrogen project
  2. Install the dependencies
  3. Check ESLint version

Expected Behavior

The Skeleton template should use ESLint 9.

Actual Behavior

The Skeleton template is using ESLint 8.x which is end of life since October 5, 2024.

https://eslint.org/blog/2024/09/eslint-v8-eol-version-support/

@wizardlyhel
Copy link
Contributor

wizardlyhel commented Oct 24, 2024

I looked into upgrading eslint on Hydrogen. Currently block by other eslint plugins not supporting eslint 9.x:

So far I have figure out the following hasn't support eslint 9.x

  • @remix-run/eslint-config
  • eslint-plugin-jest

Biggest one being @remix-run/eslint-config pinning the parser @typescript-eslint/parser
at 5.x where the latest is at 8.x which supports eslint 9.x.

We can nudge Remix team on updating @remix-run/eslint-config
Also need to fix or kill eslint-plugin-hydrogen

@tomtuv
Copy link
Author

tomtuv commented Oct 25, 2024

@wizardlyhel
Copy link
Contributor

Yea - just talked with the Remix team. We'll also move that dependency

@wizardlyhel wizardlyhel added the Bug Something isn't working label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working SEV-3
Projects
None yet
Development

No branches or pull requests

3 participants