Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo store navigation links broken #1035

Closed
rista404 opened this issue Jun 25, 2023 · 0 comments · Fixed by #1036
Closed

Demo store navigation links broken #1035

rista404 opened this issue Jun 25, 2023 · 0 comments · Fixed by #1036

Comments

@rista404
Copy link
Contributor

rista404 commented Jun 25, 2023 •
edited
Loading

Which package or tool is having this issue?

Hydrogen Demo Store

Steps to Reproduce

Go to https://hydrogen.shop/ and confirm that all of the links are "external", they are leading to https://checkout.hydrogen.shop/ which is the primary domain.

Expected Behavior

All of the links in the navigation should be internal, handled by Remix.

Actual Behavior

Yesterday I noticed that all of the links on my two headless sites are broken, since Shopify all of a sudden changed how navigation item URLs are returned.

I'll try to open a PR to fix this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use shop.primaryDomain to mark internal links in demo store rista404/hydrogen
1 participant
@rista404