-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize query for product page #918
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think line 62
has a duplicate id
that could be removed.
Also, do you mind removing as many variables as you can as well? Since these queries aren't dynamic anymore, there's no point in having those variables there I don't think.
@frehner so inline all the variables as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to removing variables, where did we land on rewriting the metafields to the new specific metafield
version?
As many as you can. I think the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Awesome work, thank you!
Description
Part of Shopify/hydrogen#778
What was done:
useShopQuery