Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: index routes #562 #566

Merged
merged 2 commits into from
Jan 31, 2022
Merged

fix: index routes #562 #566

merged 2 commits into from
Jan 31, 2022

Conversation

blittle
Copy link
Contributor

@blittle blittle commented Jan 27, 2022

Description

fix: index routes #562

Additional context

Something was different in React Router where they'd auto handle paths that end in /.

Before submitting the PR, please make sure you do the following:

  • Add your change under the Unreleased heading in the package's CHANGELOG.md
  • Read the Contributing Guidelines
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
  • Update docs in this repository for your change, if needed

@blittle blittle force-pushed the bl-fix-index-routes branch from ead09d0 to 90d6641 Compare January 27, 2022 20:27
wizardlyhel
wizardlyhel approved these changes Jan 27, 2022
View reviewed changes
Copy link
Collaborator

@wizardlyhel wizardlyhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

packages/hydrogen/src/foundation/Router/tests/DefaultRoutes.test.tsx Outdated Show resolved Hide resolved
@blittle blittle force-pushed the bl-fix-index-routes branch from a7b103d to 8fb226b Compare January 28, 2022 15:21
@blittle blittle merged commit 5702a59 into main Jan 31, 2022
@blittle blittle deleted the bl-fix-index-routes branch January 31, 2022 15:04
@jplhomer jplhomer mentioned this pull request Feb 15, 2022
Closed
@shopify-shipit shopify-shipit bot temporarily deployed to production February 24, 2022 17:32 Inactive
@scottdixon scottdixon mentioned this pull request Mar 29, 2022
Merged
4 tasks
rafaelstz pushed a commit to rafaelstz/hydrogen that referenced this pull request Mar 4, 2023
@frandiox
Remove prepack hook from CLI (Shopify#566)
740453f 
* Update package-lock.json

* Remove CLI prepack hook

* Update create-hydrogen dependency version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wizardlyhel wizardlyhel wizardlyhel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blittle @wizardlyhel