Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to Products in Cart.client.jsx of the Hydrogen template don't work #711

Closed
johncraigcole opened this issue Feb 18, 2022 · 0 comments · Fixed by #713
Closed

Links to Products in Cart.client.jsx of the Hydrogen template don't work #711

johncraigcole opened this issue Feb 18, 2022 · 0 comments · Fixed by #713

Comments

@johncraigcole
Copy link
Contributor

By not including / before products in the to prop of a Link component the user can't get to the product from the cart.

https://github.com/Shopify/hydrogen/blob/690eb80df3614e6425ed00d65913e9efac24d8c2/examples/template-hydrogen-default/src/components/Cart.client.jsx#L98

cart-link-error

Correcting the to prop of the Link component in Cart.client.jsx to be <Link to={`/products/${merchandise.product.handle}`}> will correct the issue.

blittle added a commit that referenced this issue Feb 23, 2022
* fix: corrects error with product links close (#711)

* wip: added not to Unreleased

* wip: moved to correct changelog

Co-authored-by: Bret Little <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant