Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Index routes are broken #562

Closed
scottdixon opened this issue Jan 27, 2022 · 1 comment
Closed

[BUG] Index routes are broken #562

scottdixon opened this issue Jan 27, 2022 · 1 comment
Assignees
@blittle
Labels
bug Something isn't working

Comments

@scottdixon
Copy link
Contributor

Describe the bug

@johncraigcole has reported index routes aren't being picked up.

E.g. With a /src/products/index.server.jsx component, /products shows a 404.

To Reproduce
https://stackblitz.com/edit/shopify-hydrogen-h4rvb5?file=src%2Fpages%2Fproducts%2Findex.server.jsx&title=Hydrogen

Expected behaviour
/products should load the /src/products/index.server.jsx component.

Additional context

Was working fine in 0.9.1

  • Hydrogen version 0.10.1
  • Node version 16.5
@scottdixon scottdixon added the bug Something isn't working label Jan 27, 2022
@blittle blittle self-assigned this Jan 27, 2022
blittle added a commit that referenced this issue Jan 27, 2022
@blittle
fix: index routes #562
ead09d0
@blittle blittle mentioned this issue Jan 27, 2022
Merged
4 tasks
blittle added a commit that referenced this issue Jan 27, 2022
@blittle
fix: index routes #562
90d6641
blittle added a commit that referenced this issue Jan 31, 2022
@blittle
Merge pull request #566 from Shopify/bl-fix-index-routes
5702a59 
fix: index routes #562
@jplhomer
Copy link
Contributor

Looks like this is fixed by #566

@scottdixon scottdixon mentioned this issue Mar 28, 2022
Closed
@github-actions github-actions bot mentioned this issue Mar 29, 2022
Merged
rafaelstz pushed a commit to rafaelstz/hydrogen that referenced this issue Mar 4, 2023
@blittle
Fix latest tag (Shopify#562)
5c25633
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blittle blittle

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jplhomer @blittle @scottdixon