Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

[Feature Request] - Use components without <ShopifyProvider/> #177

Closed
DavidWittness opened this issue Feb 9, 2023 · 1 comment
Closed

Comments

@DavidWittness
Copy link

As I was building the guides for hydrogen 2, some of the feedback I received was that wrapping the whole app in just to use the Shop Pay button felt strange.

Snooping on the code a bit, it looks like the only code that is being pulled from the provider is the shop ID.

Describe the solution you'd like
Include 2 ways to use Shop Pay button (and other components where it makes sense).

If wrapped in a Provider, you don't need to pass in props like shop ID.
If not wrapped in a Provider, you can pass in props to the component.

Additional context
I think the overall goal is to have something copy/pasteable that works in any context.

@frehner
Copy link
Contributor

frehner commented Feb 9, 2023

Thanks for the feedback! We're tracking this in Shopify/hydrogen#629

@frehner frehner closed this as completed Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants