Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /__health route #361

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Remove /__health route #361

merged 2 commits into from
Jan 12, 2023

Conversation

frandiox
Copy link
Contributor

Tracking here when Oxygen is able detect if the deployment is ready without using this /__health route: https://github.com/Shopify/oxygen-workers/pull/585

cc @jplhomer @slester

@slester
Copy link
Contributor

slester commented Jan 11, 2023

As of this morning, it's no longer needed. I'm still rolling it out to the GitHub action code today, however.

@slester
Copy link
Contributor

slester commented Jan 11, 2023

@frandiox - rolled out to v4 of the GitHub action. Doing v3 now but you should be good to go.

@slester
Copy link
Contributor

slester commented Jan 11, 2023

v3 complete.

@frandiox frandiox merged commit aa9c49f into v0.x-2022-10 Jan 12, 2023
@frandiox frandiox deleted the fd-remove-health-route branch January 12, 2023 10:30
@github-actions github-actions bot mentioned this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants