Pass --no-typescript if the user didn't want typescript
#342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
blittle
approved these changes
Dec 16, 2022
|
Nice — “JS as default; but first class TS support” may be a good thing to add to the decision log |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we simply don't send
--typescriptif the user said they wanted the JS version of the template (in the temp init script), or if the user didn't pass the--typescriptflag explicitly in the plugin/init script.This changes behavior slightly for the official plugin, in that it defaults to JS unless TS was specified with the flag. I think this is what we've aligned on previously (cc @benjaminsehl) so it makes sense to encode that decision here, too. We could also add the "do you want to use typescript?" to the actual
initcommand prompt, too.Regardless, this solves the issue with the temp init script in the short term.