Add support custom file prefix block #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelfelipe
force-pushed
the
add-support-custom-file-prefix
branch
from
e222fb7 to
8af2aac
Compare
dalehamel
approved these changes
Oct 16, 2023
Same for me. Added @gmcgibbon for review. Would you mind taking a look to this when you have some time 🙏 ? |
gmcgibbon
reviewed
Oct 16, 2023
gmcgibbon
approved these changes
Oct 17, 2023
manuelfelipe
force-pushed
the
add-support-custom-file-prefix
branch
from
0c23273 to
d28db96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move default file prefix behaviour out into a default block and allow for gem consumers to provide a custom block via
AppProfiler.profile_file_prefix.We need this as internally, we use the file name of exported profiles as last-resort metadata source, and the current behaviour of using timezone time is not machine friendly.