Properly close inherited servers on fork #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
requested review from
etiennebarrie,
rafaelfranca,
DazWorrall,
dalehamel,
manuelfelipe,
bmansoob and
jasonhl
casperisfine
force-pushed
the
server-close-on-fork
branch
4 times, most recently
from
9896d3f to
d4060c6
Compare
My bad on that one. |
casperisfine
force-pushed
the
server-close-on-fork
branch
from
d4060c6 to
2b13baf
Compare
I noticed some UNIXServer and AppServer accumulating with
reforking enabled.
The reason is that the `at_exit { stop }` make `Server` instances
immortal, so they are never GC, and their open socket accumulate and
are never closed.
That callback is useless anyway, as on exit the finalizer of these
objects will be invoked, and they'll cleanup after themselves.
casperisfine
force-pushed
the
server-close-on-fork
branch
from
2b13baf to
ba75236
Compare
dalehamel
approved these changes
Sep 25, 2023
No worries, it's a common footgun. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some UNIXServer and AppServer accumulating with reforking enabled.
The reason is that the
at_exit { stop }makeServerinstances immortal, so they are never GC, and their open socket accumulate and are never closed.That callback is useless anyway, as on exit the finalizer of these objects will be invoked, and they'll cleanup after themselves.