Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vernier profiles can't be viewed locally #142

Open
gmcgibbon opened this issue Oct 23, 2024 · 3 comments
Open

Vernier profiles can't be viewed locally #142

gmcgibbon opened this issue Oct 23, 2024 · 3 comments

Comments

@gmcgibbon
Copy link
Member

gmcgibbon commented Oct 23, 2024

The default viewing profile action doesn't work with Vernier profiles:

def view(params = {})
raise NotImplementedError
end
end

We should implement this so Vernier can be use out-of-the-box like Stackprof can. We can probably use profile-viewer like we do speedscope.

@dalehamel
Copy link
Member

dalehamel commented Oct 23, 2024

@gmcgibbon there is actually a PR waiting for you to review #111 we had reviewed it together but i think it fell off the radar. I just rebased it and re-fixed rubocop.

@gmcgibbon
Copy link
Member Author

gmcgibbon commented Oct 30, 2024

#111 is merged, which helps, but I'm still going to work on a local version of the middleware and that requires change the profile-viewer. Working on that next.

@dalehamel
Copy link
Member

Thanks @gmcgibbon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants