Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to the newest material-ui v4.12 #86

Closed
wants to merge 4 commits into from

Conversation

Linschlager
Copy link

Resolves #85

  • Fixed the tool to account for the new bugs in the docs
  • Ran the generator over the newer docs
  • Updated the urls to account for the legacy status
  • Made some small adjustments to get the Generator work on non-Windows

- Fixed the tool to account for the new bugs in the docs
- Ran the generator over the newer docs
- Updated the links to account for the legacy status
@JustinWick
Copy link

Unfortunately @Shmew hasn't been active on here or Twitter since very early July 2021. It's possible something has happened to him :-/

@JustinWick
Copy link

JustinWick commented Jan 19, 2022

Is there any way to use the updated version in this branch in a project that uses paket and yarn?

@marcpiechura
Copy link

Maybe we should fork it to Feliz.MUI and work on bindings for V5?

@JustinWick
Copy link

@Linschlager: Thoughts here?

I'd love @marcpiechura's suggestion, but at this point even just figuring out how to get this into a dependent project's package managers would unblock me :)

@marcpiechura
Copy link

marcpiechura commented Jan 22, 2022

@JustinWick . you could build the pull request branch locally and reference the dll directly, instead of the nuget package and then update the npm package separately.

@halcwb
Copy link

halcwb commented Jan 22, 2022

@Linschlager did you update the baseUrl? Because I think https://material-ui.com will now point to the api docs for v5. The legacy version 4 is still available at: https://v4.mui.com/.

@Linschlager
Copy link
Author

Linschlager commented Jan 22, 2022

@Linschlager did you update the baseUrl? Because I think https://material-ui.com will now point to the api docs for v5. The legacy version 4 is still available at: https://v4.mui.com/.

@JustinWick Yes, I did. (HtmlCache.fs in a few places) - Although I may have missed some occurrences

Maybe we should fork it to Feliz.MUI and work on bindings for V5?

@marcpiechura I think this would be the only sustainable option for moving forward.
The transition to v5 should be relatively straightforward as they kept most of the structure in their docs (apart from the styling, but that's irrelevant for the transformer). When I find some time in the next week, I'll try to get a POC going on my fork

@halcwb
Copy link

halcwb commented Jan 22, 2022

@Linschlager I think if you change this, all references will be correct:

let refresh =
  async {
    let baseUrl = "https://v4.mui.com" //"https://material-ui.com"

...

This is in the HtmlCache.fs.

@Linschlager
Copy link
Author

@Linschlager I think if you change this, all references will be correct:

let refresh =
  async {
    let baseUrl = "https://v4.mui.com" //"https://material-ui.com"

...

This is in the HtmlCache.fs.

Not fully. Common.fs also needs to fix the relative links so the crawler can fetch the files correctly

@JustinWick
Copy link

Any plans to continue this? I'd be using v5 now if this were available!

I'd help out, though I know less than nothing about modern JS frameworks, I'm a backend/embedded guy, the last time I got paid to make a GUI for a webpage was 20 years ago.

@Linschlager
Copy link
Author

Linschlager commented Feb 22, 2022

Any plans to continue this? I'd be using v5 now if this were available!

I'd help out, though I know less than nothing about modern JS frameworks, I'm a backend/embedded guy, the last time I got paid to make a GUI for a webpage was 20 years ago.

@JustinWick I have a WIP Mui5 version on my branch, though it will probably take a while for me to finalize fixing all the special cases
Not sure it makes sense to publish this updated package if the end-goal is to upgrade to Mui5 anyway and a lot of things are going to change

@Linschlager
Copy link
Author

Closing this in favor of the MuiV5 "PR"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keeping up to date?
4 participants