Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_dataset duplicate check should use make_entry_id helper #96

Open
ressy opened this issue Jan 20, 2023 · 0 comments
Open

load_dataset duplicate check should use make_entry_id helper #96

ressy opened this issue Jan 20, 2023 · 0 comments
Milestone

Comments

@ressy
Copy link
Member

ressy commented Jan 20, 2023

I have undocumented support for an optional Dataset column for datasets in some places, but #90's change uses its own list of column names. I should make that consistent by replacing this in load_dataset:

cts <- table(with(data, paste(Sample, Replicate, Locus, sep = "/")))

with this:

cts <- table(make_entry_id(data))
@ressy ressy added this to the Version 0.5.0 milestone Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant