Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] swipe up should be normal when we have a horizontal swipe #43

Closed
yassinrais opened this issue May 6, 2021 · 3 comments · Fixed by #44
Closed

[BUG] swipe up should be normal when we have a horizontal swipe #43

yassinrais opened this issue May 6, 2021 · 3 comments · Fixed by #44

Comments

@yassinrais
Copy link

Hello SharifClick !
Before all thanks for the template 💖

There a problem about swipe to up
when we have a horizontal swipe, in mobile we don't have scroll button, so when we try to swipe up to go to end of page
the swipe svelte does not allow to do a normal scroll

if it's possible to fix this as soon, I will be more thankful 🙇‍♂️

Thanks !

@SharifClick
Copy link
Owner

Hi @yassinrais , You are welcome.
Can you elaborate that bug putting a demo on repl.
We will fix the following issue asap.

@yassinrais
Copy link
Author

those demos (horizontal one), existed already and they have the same issue , take an example of a horizontal swipe and try to scroll from mobile but in the swipe area because I used it in an app, and there the swipe part that take the full phone screen, and when user tries to do scroll he can't because the vertical swipe not let the event of scrolling (preventdefault) 😊

if you need more information , i will try to give you somthing more advanced 👌
thanks.

@SharifClick SharifClick linked a pull request May 10, 2021 that will close this issue
@SharifClick
Copy link
Owner

Hi @yassinrais ,
Just made a PR with that fix.
Will merge and release tomorrow after manual testing is done by my side.
cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants