Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joining a group with multiple courses #1780

Closed
nilsreichardt opened this issue Oct 30, 2024 · 0 comments · Fixed by #1781
Closed

Joining a group with multiple courses #1780

nilsreichardt opened this issue Oct 30, 2024 · 0 comments · Fixed by #1781
Labels
bug Something isn't working. feature: groups Groups umbrella term for courses and classes.

Comments

@nilsreichardt
Copy link
Member

nilsreichardt commented Oct 30, 2024

Description

When a user tries to join a school class that has multiple courses a dialog with a course selection is opened. Until now everything is as expected. However, when you press "Fertig" to confirm the selection the app doesn't join the courses. It just pops the dialog.

Demo

short.mp4

Steps to reproduce

  1. User A: Create a school class with courses
  2. User B: Should try to join the school class

Logs

I/flutter (29154): ----------------FIREBASE CRASHLYTICS----------------
I/flutter (29154): Null check operator used on a null value
I/flutter (29154): #0      GroupJoinBloc.enterValueWithCourseList (package:sharezone/groups/group_join/bloc/group_join_bloc.dart:58:35)
I/flutter (29154): #1      GroupJoinSelectCoursesBloc.submit (package:sharezone/groups/group_join/bloc/group_join_select_courses_bloc.dart:66:25)
I/flutter (29154): #2      _FinishButton.build.<anonymous closure> (package:sharezone/groups/group_join/pages/group_join_course_selection_page.dart:138:16)
I/flutter (29154): #3      _InkResponseState.handleTap (package:flutter/src/material/ink_well.dart:1170:21)
I/flutter (29154): #4      GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:351:24)
I/flutter (29154): #5      TapGestureRecognizer.handleTapUp (package:flutter/src/gestures/tap.dart:656:11)
I/flutter (29154): #6      BaseTapGestureRecognizer._checkUp (package:flutter/src/gestures/tap.dart:313:5)
I/flutter (29154): #7      BaseTapGestureRecognizer.handlePrimaryPointer (package:flutter/src/gestures/tap.dart:246:7)
I/flutter (29154): #8      PrimaryPointerGestureRecognizer.handleEvent (package:flutter/src/gestures/recognizer.dart:703:9)
I/flutter (29154): #9      PointerRouter._dispatch (package:flutter/src/gestures/pointer_router
I/flutter (29154): ----------------------------------------------------
@nilsreichardt nilsreichardt added bug Something isn't working. feature: groups Groups umbrella term for courses and classes. labels Oct 30, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in Triage Oct 30, 2024
@nilsreichardt nilsreichardt moved this from Needs triage to Soon-ish in Triage Oct 30, 2024
@github-project-automation github-project-automation bot moved this from Soon-ish to Closed in Triage Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. feature: groups Groups umbrella term for courses and classes.
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

1 participant