Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] [Localization] Add %s to affix localizations to allow more reasonable affixed item names for some languages #1222

Open
RaymondBlaze opened this issue Apr 1, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@RaymondBlaze
Copy link

Currently, prefix and suffix are in the form of adj. and of noun. and added to the beginning/end of the item name.

This is reasonable for most language like English, however, languages like Chinese don't actually have a proper equivalent for suffix of noun.. More specifically, the common grammar for Chinese to express the meaning of suffix of noun. is usually something equivalent to prefix noun.'s. Additionally, Chinese doesn't use blank spaces to separate words.

In this case, the current implementation results in affixed item names looking bizarre in Chinese. I believe passing in the original or partial affixed item name as %s(eg. Aquatic -> Aquatic %s, of the Ocean -> %s of the Ocean) would allow localizations to have the freedom to format the name in their own grammar, thus making a better experience for players.

I am willing to make a PR for this feature if needed.

@Shadows-of-Fire
Copy link
Owner

The way that the actual affix name works is not compatible with such a structure, because of the component heirarchy. I have to maintain the original item name, which means the prefix/suffix components are not aware of eachother atm. It may be possible to change this for future versions, but it would brick all existing name formatting to do so in the middle of a MC version.

As of now, the concatenation rules are controlled by the following language keys, which are editable:

    "misc.apotheosis.affix_name.two": "%s %s",
    "misc.apotheosis.affix_name.three": "%s %s %s",
    "misc.apotheosis.affix_name.four": "%s %s %s %s",

.two is used for <prefix> <base name>
.three is used for <prefix> <base name> <suffix>
.four is used for <boss name> <prefix> <base name> <suffix>

@Shadows-of-Fire Shadows-of-Fire added the enhancement New feature or request label May 5, 2024
@Shadows-of-Fire
Copy link
Owner

cc @mc-kaishixiaxue if you have any ideas on how to improve the structure going forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants