Add optional built building count to recipe rows v2 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variable, which defaults to null, can be used to track the number of buildings that have actually been built. This number has no impact on the model.
Dropdown menu items for setting or clearing the builtBuildings value have been added for each recipe row. These items mirror the behavior and implementation of those for fixedBuildings, for the most part. The initial value is buildingCount rounded up, or 0 if buildingCount is negative. As 0 is a valid value, clearing builtBuildings returns it to null. Shopping lists now use the builtBuildings value instead of buildingCount if the former is not null.
The text field is only visible if builtBuildings is not null, and is placed under the building count. It is colored grey to indicate that it is not playing a role in the model.
If the number of buildings needed for the model's solution is greater than the specified number of built buildings, the recipe will now be flagged accordingly. This makes it substantially easier to determine which recipes need to be revisited if a change is made.
To make issues more apparent, the entire page now displays an error message (like with deadlocks) if a recipe needs more machines than it currenty has built.
veger
force-pushed
the
build-amount-v2
branch
from
f87cf71
to
910bb55
Compare
veger
force-pushed
the
build-amount-v2
branch
from
910bb55
to
87e19bb
Compare
Yukinyaa
pushed a commit
to Yukinyaa/yafc
that referenced
this pull request
Jun 11, 2024
This adds a new preference (and alters the UI for an existing one) to allow you to choose how much to scale down certain icons:  The default is 90%, which is the middle size in this gif. The other two sizes shown are 80% and 100%; 100% shows the issue where the background color is not visible, hiding the link information.  The Desired products, Summary ingredients, and Extra products icons all scale too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends PR #118 by making the check recursive so it shows the error on the top recipe and all subgroups until the actual recipe that has not enough buildings.