Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in 02_fundamentals/Code.ipynb #8

Open
ScytheMax opened this issue Feb 7, 2021 · 0 comments
Open

Typo in 02_fundamentals/Code.ipynb #8

ScytheMax opened this issue Feb 7, 2021 · 0 comments

Comments

@ScytheMax
Copy link

Dear Mr. Weidman,

I am currently trying to understand the code in [45], the function "loss_gradients".

I just want to ask, if in the line
loss_gradients['B1'] = dLdB1.sum(axis=0)

it should be written instead:
loss_gradients['B1'] = dLdB1

Reason:
The expression dLdB1 in my test project shows me, that the dimension of it is (hidden_size,1).
Also the dimension of weights['B1'] is (hidden_size,1).
If the expression additonally sum over all [hidden_size] entries, then each [hidden_size] entry of weights['B1'] is updated with the same value. That seems not correct for me.

Best Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant