Skip to content
This repository has been archived by the owner on May 3, 2020. It is now read-only.

Spacing Issues on Newest Version #553

Open
kmackinley opened this issue Mar 4, 2019 · 9 comments
Open

Spacing Issues on Newest Version #553

kmackinley opened this issue Mar 4, 2019 · 9 comments

Comments

@kmackinley
Copy link

Please fill out the Bug Form or Feature Request Below


Bug

Describe the issue and steps to reproduce

  1. Upload template
  2. Generate report to find random spacing issues.

Example Use Case

I have not been able to pinpoint this issue. However, since the new version, my uploaded templates randomly delete spaces in random areas. I've checked formatting on the Word templates and there is no formatting on some of the areas where the spaces are removed. As a painful workaround (only sometimes, not all) copying the text into Sublime and copying it back into the documents resolves the issue; suggesting formatting where there is none visible in the document (even when "showing formatting"). Again, this is only happening with the newest version.

I can provide examples if needed, but unsure as to how they would help since no markup language is used where the deletion of spaces happens.

@MaxNad
Copy link
Collaborator

MaxNad commented Mar 5, 2019

Hi,
Just to make sure I can pinpoint the problem, are you running the latest release or straight from master ?
Thanks.

@kmackinley
Copy link
Author

This is from the latest release.

@Clickb8
Copy link

Clickb8 commented Mar 29, 2019

Hi,
Any update regarding this issue ? I have the same problem: Spaces are randomly deleted when generating a report. I am using the latest release too (from deb package) and a custom Word template.
Thanks

@kmackinley
Copy link
Author

I'd like to note on this issue that it seems to be resolved in the source version, whereas the current release has these weird spacing issues.

@Sn00z3r
Copy link

Sn00z3r commented May 17, 2019

Anybody have any idea which code part is responsible here, because I would like to "patch" our production serpico to fix this issue and I'm not really keen on just overwriting all files :)

@BuffaloWill
Copy link
Contributor

@Sn00z3r have you tested the source version? This issue has been fixed in master. Monkey patching your code will have unintended consequences.

That being said, the code responsible is helpers/xslt_generatio.rb and specifically this commit; 456c45b#diff-1700bffbf6519338fbe0c4702ca11c15.

@jakxx
Copy link
Contributor

jakxx commented May 31, 2019

Finding this issue myself as well. Would it be worth pushing a new release for this fix?

@BuffaloWill
Copy link
Contributor

I agree we should push a new release. It is well past due, let me look at the timeline for this.

@jakxx
Copy link
Contributor

jakxx commented Nov 25, 2019

Any more thoughts on getting this one (and others) into a new release?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants