-
-
Notifications
You must be signed in to change notification settings - Fork 0
/
select_map.rb
61 lines (50 loc) · 1.69 KB
/
select_map.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
# frozen_string_literal: true
module RuboCop
module Cop
module Performance
# In Ruby 2.7, `Enumerable#filter_map` has been added.
#
# This cop identifies places where `select.map` can be replaced by `filter_map`.
#
# @example
# # bad
# ary.select(&:foo).map(&:bar)
# ary.filter(&:foo).map(&:bar)
#
# # good
# ary.filter_map { |o| o.bar if o.foo }
#
class SelectMap < Base
include RangeHelp
extend TargetRubyVersion
minimum_target_ruby_version 2.7
MSG = 'Use `filter_map` instead of `%<method_name>s.map`.'
RESTRICT_ON_SEND = %i[select filter].freeze
def_node_matcher :bad_method?, <<~PATTERN
(send nil? :bad_method ...)
PATTERN
def on_send(node)
return if (first_argument = node.first_argument) && !first_argument.block_pass_type?
return unless (send_node = map_method_candidate(node))
return unless send_node.method?(:map)
map_method = send_node.parent&.block_type? ? send_node.parent : send_node
range = offense_range(node, map_method)
add_offense(range, message: format(MSG, method_name: node.method_name))
end
alias on_csend on_send
private
def map_method_candidate(node)
return unless (parent = node.parent)
if parent.block_type? && parent.parent&.send_type?
parent.parent
elsif parent.send_type?
parent
end
end
def offense_range(node, map_method)
range_between(node.loc.selector.begin_pos, map_method.source_range.end_pos)
end
end
end
end
end