Allows parametrizing requests' session

[miguelius]

This version handles all calls to requests to a function which returns session object customizable. In this case we can disable verify ssl. This could fix #219.

Usage:

    driver_path = GeckoDriverManager().dont_verify_ssl().install()
    ff = webdriver.Firefox(executable_path=driver_path)
    ff.get("http://automation-remarks.com")
    ff.quit()

[pep8speaks]

Hello @miguelius! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-10-18 09:53:10 UTC

[miguelius]

Hi @SergeyPirogov! Is it possible to run the workflow? If it works, how far is it of being included in a release?

Thank you very much!

Cheers!

[miguelius]

Fixed conflicts!

[aleksandr-kotlyar]

Also: Closes #226

[miguelius]

Conflict resolved!

[aleksandr-kotlyar]

@miguelius i am not sure that using globals is necessary. May be it's better to realize through variable like

driver =  EdgeChromiumDriverManager(ssl_verify=False).install()

[aleksandr-kotlyar]

And it is also #211 - with same request but with a bit larger functionality. We can take ssl_verify from this as example. And implement only this for now, then think about proxies.

[miguelius]

Using an argument in the constructor was my first call, still I had problems with function download_file, which calls directly to requests.

While it's implemented using a global hidden variable, this means it only could be used by session() function and reset by new_session(), It's more like a singleton withouth the boiler plate. Nobody uses the _session variable. And it was the shortest path with minimum impact in the code without changing any method signatures.

#211 isn't enough, because you still have the problem with ssl verification when you are using https proxy.

I'll propose you an alternative in another pr. I believe requests session should be the parameter, and this should be used by both the webdrivermanager an utility functions in order to work properly.

Thank you for your time!
** edited: tried to clarify a paragraph, corrected negation and any use, and added the thank you I forgot in the first version of the comment 😄

[miguelius]

better implementation available!