Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEFECT] Incorrect LATEST_STABLE build version link for Edge on Linux in webdriver_manager=3.5.0 #242

Closed
rsavu98 opened this issue Oct 10, 2021 · 5 comments · Fixed by #249
Assignees

Comments

@rsavu98
Copy link

rsavu98 commented Oct 10, 2021

Code from driver.py

class EdgeChromiumDriver(Driver):
    def __init__(self, name, version, os_type, url, latest_release_url):
        super(EdgeChromiumDriver, self).__init__(name, version, os_type, url,
                                                 latest_release_url)
        self.browser_version = ""

    def get_latest_release_version(self):
        # type: () -> str
        if os_name() == OSType.LINUX:
            latest_release_url = "https://msedgedriver.azureedge.net/LATEST_STABLE"
        else:
            major_edge_version = chrome_version(ChromeType.MSEDGE).split(".")[0]
            latest_release_url = self._latest_release_url + '_' + major_edge_version
        resp = requests.get(latest_release_url)
        validate_response(resp)
        return resp.text.rstrip()
        

Currently, there are only Beta and Dev versions available for Linux, but the latest_release_url points to the latest stable build version which is not available for Linux.
It should be either latest_release_url = "https://msedgedriver.azureedge.net/LATEST_BETA" or latest_release_url = "https://msedgedriver.azureedge.net/LATEST_DEV" since only these Edge builds are available for Linux.

Please let me know if you need any more details. I'll be happy to provide them.
Thanks

@aleksandr-kotlyar
Copy link
Collaborator

aleksandr-kotlyar commented Oct 11, 2021

@rsavu98 please provide more details

  • os package of linux
  • edge browser version available now at this os repo (and installed on your machine)
  • latest_stable version of edge driver what you saw

I will try to reproduce on virtual machine and find a solution if there is an issue.

@rsavu98
Copy link
Author

rsavu98 commented Oct 11, 2021

Hi @aleksandr-kotlyar, thanks for a quick reply!

  • os package of Linux - Ubuntu 20.04.3 LTS
  • Browsers version installed in my machine: Edge Beta - Version 95.0.1020.14. Edge Dev - Version 96.0.1032.0.
  • The code points me to the 94.0.992.38 latest_stable version
    The error I'm getting:
[WDM] - There is no [linux64] edgedriver for browser  in cache
[WDM] - Trying to download new driver from https://msedgedriver.azureedge.net/94.0.992.38/edgedriver_linux64.zip

I copied the link from the error above and here's the result.
image

@aleksandr-kotlyar
Copy link
Collaborator

aleksandr-kotlyar commented Oct 11, 2021

@rsavu98 how do you check edge version at ubuntu? What command do you use?

Upd: and how do you install them? What commands apt-get ... smth-edge-word-with-what-word?

@rsavu98
Copy link
Author

rsavu98 commented Oct 11, 2021

@aleksandr-kotlyar I check the Edge version in the Settings of the browser.
image
I've installed the Edge browser using this link https://www.microsoftedgeinsider.com/en-us/download?platform=linux-deb and then double-click on the downloaded .deb file to complete the installation.

aleksandr-kotlyar added a commit to aleksandr-kotlyar/webdriver_manager that referenced this issue Oct 16, 2021
- Feature: finding EdgeDriver version for MAC & LINUX depends on MSEdge browser version and OS type (Closes SergeyPirogov#243, SergeyPirogov#242)
- Fix: Add rights to execute edgedriver binary on linux.
- Test Coverage: More tests for EdgeDriver & testing on LINUX/MAC in CI.
- bump version to 3.5.2
- delete requirements.txt
aleksandr-kotlyar added a commit to aleksandr-kotlyar/webdriver_manager that referenced this issue Oct 16, 2021
…version and OS type

- Feature: finding EdgeDriver version for MAC & LINUX depends on MSEdge browser version and OS type (Closes SergeyPirogov#243, SergeyPirogov#242)
- Fix: Add rights to execute edgedriver binary on linux.
- Test Coverage: More tests for EdgeDriver & testing on LINUX/MAC in CI.
- delete requirements.txt
SergeyPirogov pushed a commit that referenced this issue Oct 16, 2021
…version and OS type (#249)

- Feature: finding EdgeDriver version for MAC & LINUX depends on MSEdge browser version and OS type (Closes #243, #242)
- Fix: Add rights to execute edgedriver binary on linux.
- Test Coverage: More tests for EdgeDriver & testing on LINUX/MAC in CI.
- delete requirements.txt
miguelius pushed a commit to miguelius/webdriver_manager that referenced this issue Oct 18, 2021
…version and OS type (SergeyPirogov#249)

- Feature: finding EdgeDriver version for MAC & LINUX depends on MSEdge browser version and OS type (Closes SergeyPirogov#243, SergeyPirogov#242)
- Fix: Add rights to execute edgedriver binary on linux.
- Test Coverage: More tests for EdgeDriver & testing on LINUX/MAC in CI.
- delete requirements.txt
@rsavu98
Copy link
Author

rsavu98 commented Oct 22, 2021

@aleksandr-kotlyar, thanks a lot for a quick fix! It works now.

@aleksandr-kotlyar aleksandr-kotlyar self-assigned this May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants